Change default behavior of resolve bibtex strings #8382

Siedlerchr · 2022-01-03T20:17:32Z

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr · 2022-01-03T22:37:46Z

Discussion: Invert logic And resolve fields only for the following list:
Author, BookAuthor, Title, Editor , Journal + JournalTitle + SubTitile etc
Editor a, b,c Issue + SubTitle, MainTitle, MainSubTitle, MainTitleAddon, Publisher, shortAuthor + Editor + Title

TODO: Double braces in Changelog

src/main/java/org/jabref/migrations/PreferencesMigrations.java

* upstream/main: Observable Preferences J (Preview) and minor refactor (#8370) quickfix (#8383) Live reloading when switching themes (#7336)

Siedlerchr · 2022-01-05T15:26:56Z

add field month to string resolving

Fix changelog

koppor

Some small nitpick regarding the negation - and two additional fields. 😇

src/main/java/org/jabref/gui/preferences/file/FileTab.fxml

src/main/java/org/jabref/preferences/JabRefPreferences.java

* 'main' of github.com:JabRef/jabref: Replace master with main

…gResolving * 'stringResolving' of github.com:JabRef/jabref: Fix typos

koppor · 2022-01-09T10:02:39Z

I worked on the preferences tab to improve the UI by grouping the preferences for "File" together:

koppor · 2022-01-09T10:04:44Z

I would now like to add test cases for the fields mentioned in the fixed issues. I know, It's "only" a preference (mocking) thing. However, I would like to have more tests to ensure that nothing breaks if we touch this part of the code at a later time.

calixtus · 2022-01-09T13:02:10Z

Do you want to test the FieldWriter with the mentioned fields in this PR or do you want to test the preferences if they return the right fields? I don't think the latter would be meaningful at all...

Btw., this PR is still a draft...

src/test/java/org/jabref/logic/bibtex/FieldWriterTests.java

* upstream/main: Fix plural s in library properties tab (#8402)

- Add org.jabref.logic.bibtex.FieldWriter#BIBTEX_STRING_START_END_SYMBOL - !doNotResolveStrings -> resolveStrings

Siedlerchr · 2022-01-09T18:34:26Z

failing fetcher test is grobid

koppor · 2022-01-09T19:31:59Z

I added the BibTeX field content of the three linked issues as tests (verbatimely).

Siedlerchr · 2022-01-09T20:18:25Z

I am not sure if your negation change doesn't break anything

koppor · 2022-01-10T05:24:23Z

Side note: I find isEnabled more readable than !isDisabled. Pattern "Avoid Negations", page 4, in Java by Comparison.

I am not sure if your negation change doesn't break anything

Tests run through :) -- In case one has a gut feeling something could break, please provide examples, and I am happy to craft tests.
I replace the negative clause by positive one and adding !.
All positive parameters (true) have been replaced by negative ones (false) and vice versa
"in a distributive lattice, an element has, at most, one complement" (https://math.stackexchange.com/a/3439133/75732)

koppor · 2022-01-10T05:25:53Z

The only thing, I did not touch is the storing in the registry. There, the negegation is still stored.

calixtus · 2022-01-10T07:43:10Z

src/main/java/org/jabref/logic/bibtex/FieldWriter.java

@@ -163,7 +168,7 @@ private String formatAndResolveStrings(String content, Field field) throws Inval
    }

    private boolean shouldResolveStrings(Field field) {
-        if (!preferences.isDoNotResolveStrings()) {
+        if (preferences.isResolveStrings()) {


shouldResolveStrings?

Follow-up PR 😇

Siedlerchr · 2022-01-13T21:05:59Z

After looking again at the changes, it looks good and I will merge it now

Change default behavior of resolve bibtex strings

e69c84f

Fixes #7010 Fixes #7012 Fixes #8303

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 3, 2022

Siedlerchr removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 3, 2022

Siedlerchr marked this pull request as draft January 3, 2022 23:04

tobiasdiez reviewed Jan 4, 2022

View reviewed changes

src/main/java/org/jabref/migrations/PreferencesMigrations.java Outdated Show resolved Hide resolved

Siedlerchr added 4 commits January 4, 2022 13:33

Merge remote-tracking branch 'upstream/main' into stringResolving

ae29ece

* upstream/main: Observable Preferences J (Preview) and minor refactor (#8370) quickfix (#8383) Live reloading when switching themes (#7336)

Renaming of fields

30e6b54

fix prefs, remove migration

56f2f8a

Fix gui properties and l10n

fa84969

adjust defaults, fix bst tests

ef2c916

Siedlerchr marked this pull request as ready for review January 6, 2022 20:15

Siedlerchr added 3 commits January 6, 2022 21:49

remove obsolete test

ba865d2

Fix changelog

fix checkstyle

8b2f76f

fix another test

7975ea4

Siedlerchr requested a review from koppor January 6, 2022 21:28

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 7, 2022

Siedlerchr and others added 2 commits January 7, 2022 17:23

fix comment

adbb12d

Fix typos

3c81834

koppor requested changes Jan 7, 2022

View reviewed changes

src/main/java/org/jabref/gui/preferences/file/FileTab.fxml Show resolved Hide resolved

src/main/java/org/jabref/gui/preferences/file/FileTab.fxml Outdated Show resolved Hide resolved

src/main/java/org/jabref/preferences/JabRefPreferences.java Outdated Show resolved Hide resolved

Siedlerchr and others added 4 commits January 8, 2022 18:51

Merge branch 'main' of github.com:JabRef/jabref into stringResolving

d3ba9a1

* 'main' of github.com:JabRef/jabref: Replace master with main

Merge branch 'stringResolving' of github.com:JabRef/jabref into strin…

3e264ef

…gResolving * 'stringResolving' of github.com:JabRef/jabref: Fix typos

add institution

df38fe9

Sort fields alphabetically

4dd29d3

koppor marked this pull request as draft January 9, 2022 09:46

Group prefernces at "File": BibTeX strings, Loading, Saving

3d54f61

Siedlerchr commented Jan 9, 2022

View reviewed changes

src/test/java/org/jabref/logic/bibtex/FieldWriterTests.java Outdated Show resolved Hide resolved

Siedlerchr and others added 3 commits January 9, 2022 14:46

Merge branch 'main' into stringResolving

ce0a098

Remove unused imports

adae72a

Add ADR-0024

83438f2

koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 9, 2022

Siedlerchr and others added 10 commits January 9, 2022 15:14

Add test for comment field

ec82fbb

Merge remote-tracking branch 'upstream/main' into stringResolving

48dbc3a

* upstream/main: Fix plural s in library properties tab (#8402)

fix tests

00ae093

Fix markdown in ADR-0024

97e6bb2

ADR-0024: Fix filename and addr to adr.md

2922009

ADR-0019: Fix typo

ab7f578

Merge remote-tracking branch 'origin/main' into stringResolving

fb4e8f9

Remove obsolete empty line

3395f56

Introduce BIBTEX_STRING_START_END_SYMBOL and remove negation

895d210

- Add org.jabref.logic.bibtex.FieldWriter#BIBTEX_STRING_START_END_SYMBOL - !doNotResolveStrings -> resolveStrings

Remove deprecated constructor FieldWriterPreferences()

21ab02f

Siedlerchr marked this pull request as ready for review January 9, 2022 18:36

koppor added 4 commits January 9, 2022 19:50

Fix test on Windows (CRLF issue)

242a203

Add missing context information

beda8ab

Add more tests

6c56ad4

Fix negation

1f38378

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 9, 2022

calixtus reviewed Jan 10, 2022

View reviewed changes

Siedlerchr merged commit ccf20b4 into main Jan 13, 2022

Siedlerchr deleted the stringResolving branch January 13, 2022 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change default behavior of resolve bibtex strings #8382

Change default behavior of resolve bibtex strings #8382

Siedlerchr commented Jan 3, 2022 •

edited

Loading

Siedlerchr commented Jan 3, 2022 •

edited

Loading

Siedlerchr commented Jan 5, 2022

koppor left a comment

koppor commented Jan 9, 2022

koppor commented Jan 9, 2022

calixtus commented Jan 9, 2022

Siedlerchr commented Jan 9, 2022

koppor commented Jan 9, 2022

Siedlerchr commented Jan 9, 2022

koppor commented Jan 10, 2022

koppor commented Jan 10, 2022

calixtus Jan 10, 2022

koppor Jan 13, 2022

Siedlerchr commented Jan 13, 2022

Change default behavior of resolve bibtex strings #8382

Change default behavior of resolve bibtex strings #8382

Conversation

Siedlerchr commented Jan 3, 2022 • edited Loading

Siedlerchr commented Jan 3, 2022 • edited Loading

Siedlerchr commented Jan 5, 2022

koppor left a comment

Choose a reason for hiding this comment

koppor commented Jan 9, 2022

koppor commented Jan 9, 2022

calixtus commented Jan 9, 2022

Siedlerchr commented Jan 9, 2022

koppor commented Jan 9, 2022

Siedlerchr commented Jan 9, 2022

koppor commented Jan 10, 2022

koppor commented Jan 10, 2022

calixtus Jan 10, 2022

Choose a reason for hiding this comment

koppor Jan 13, 2022

Choose a reason for hiding this comment

Siedlerchr commented Jan 13, 2022

Siedlerchr commented Jan 3, 2022 •

edited

Loading

Siedlerchr commented Jan 3, 2022 •

edited

Loading