-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integrity check for tilde accents in author names #9097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please have a look at the failing tests |
Siedlerchr
added
the
status: changes required
Pull requests that are not yet complete
label
Aug 31, 2022
Siedlerchr
added
status: ready-for-review
Pull Requests that are ready to be reviewed by the maintainers
and removed
status: changes required
Pull requests that are not yet complete
labels
Sep 3, 2022
Siedlerchr
changed the title
Solving tilde error in author names #8071
Fix integrity check
Sep 3, 2022
Siedlerchr
changed the title
Fix integrity check
Fix integrity check for tilde accents in author names
Sep 3, 2022
0x002A
approved these changes
Sep 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Siedlerchr
added a commit
that referenced
this pull request
Sep 3, 2022
* upstream/main: Fix parsing of JabRef v5.7 study.yml files (#9124) Fix integrity check for tilde accents in author names (#9097) Rework the Define study parameters dialog (#9123) Fix parsing of save actions (#9122) Fix exception that occurs when saving name formatters (#9121) Refine code for BibEntry#replaceDownloadedFile (#9118)
Siedlerchr
added a commit
that referenced
this pull request
Sep 3, 2022
…nto linkedFilesfixesRelative * 'linkedFilesfixesRelative' of github.com:JabRef/jabref: (52 commits) Enable files/files Don't show the info button when the authors field content is identical (#9128) "study.yml" is static now (#9125) fix l10n Compile fix Fix parsing of JabRef v5.7 study.yml files (#9124) Fix integrity check for tilde accents in author names (#9097) Rework the Define study parameters dialog (#9123) Fix parsing of save actions (#9122) Fix exception that occurs when saving name formatters (#9121) Refine code for BibEntry#replaceDownloadedFile (#9118) Show a warning in the merge dialog when authors are the same but formatted differently (#9088) Fix subdatabase from aux on cli (#9117) Visual improvements to LinkedFilesEditor (#9114) SLR Remove "last-search-date" (#9116) Hide diffs when one of the field values is blank a.k.a no conflict (#9110) Squashed 'buildres/csl/csl-locales/' changes from e637746677..b2afeb4d87 Squashed 'buildres/csl/csl-styles/' changes from c750b6e..8d69f16 Fix title case capitalization after en-dash characters (#9102) Update journal abbrev list (#9109) ...
Siedlerchr
added a commit
to LIM0000/jabref
that referenced
this pull request
Sep 4, 2022
* upstream/main: (111 commits) Fix link and remove obsolete FAQ Rename 'Close' to 'Cancel' in the External Changes Resolver dialog (JabRef#9130) Tiny rephrasing Linked files with an absolute path can be opened again (JabRef#9129) Oberservable Preferences M (CleanupPreferences) (JabRef#9126) fix broken link Fix broken link Fix old JabRef linked files containing the file directory as element in the filename (JabRef#9046) PDFs are not stored next to .bib file if file directory is configured (JabRef#9113) Remove double stateManager.activeDatabaseProperty() (JabRef#9127) Don't show the info button when the authors field content is identical (JabRef#9128) "study.yml" is static now (JabRef#9125) fix l10n Compile fix Fix parsing of JabRef v5.7 study.yml files (JabRef#9124) Fix integrity check for tilde accents in author names (JabRef#9097) Rework the Define study parameters dialog (JabRef#9123) Fix parsing of save actions (JabRef#9122) Fix exception that occurs when saving name formatters (JabRef#9121) Refine code for BibEntry#replaceDownloadedFile (JabRef#9118) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed tilde accent issue in author names
Fixes #8071
#8071
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)