Minor code improvements in library properties dialog #9265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly changing an observable list to an ordinary readonly list, which is sufficient and slightly more performant.
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
approved these changes
Oct 20, 2022
Siedlerchr
added a commit
that referenced
this pull request
Oct 21, 2022
* upstream/main: (28 commits) Minor code improvements in library properties dialog (#9265) Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition (#9255) Removed swing from default file dir detection (#9222) Make autosave tick in shared database opening dialog active (#9258) Bump controlsfx from 11.1.1 to 11.1.2 (#9261) Bump actions/configure-pages from 1 to 2 (#9262) Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (#9259) Bump gittools/actions from 0.9.13 to 0.9.14 (#9260) Fix for resizing cleanup entries dialog (#9240) Refresh example styles Squashed 'buildres/csl/csl-locales/' changes from cb98d36691..e243665390 Squashed 'buildres/csl/csl-styles/' changes from 7bde3e4..4eee79a Fix casing Update contributing.md Remove obsolete Jekyll howto Updates Just-the-Docs from 0.3.3 to 0.4.0.rc3 (#9249) Place subgroups w.r.t. alphabetical ordering (#9228) DOAB Fetcher now fetches ISBN and imprint fields where possible (#9229) ISSUE-9145: implement isbn fetcher (#9205) Remove explicit javafx jmod stuff (#9245) ...
Siedlerchr
added a commit
to TheGor1lla/jabref
that referenced
this pull request
Oct 21, 2022
* upstream/main: [WIP] Add GitHub action: Greetings.yml - Automates advice to JabRefs first time code contributors (JabRef#9272) Minor code improvements in library properties dialog (JabRef#9265) Adjust and make tests for BibTex/Biblatex/CSL mapping more accurate by adding Apa 7th edition (JabRef#9255) Removed swing from default file dir detection (JabRef#9222) Make autosave tick in shared database opening dialog active (JabRef#9258) Bump controlsfx from 11.1.1 to 11.1.2 (JabRef#9261) Bump actions/configure-pages from 1 to 2 (JabRef#9262) Bump hmarr/auto-approve-action from 2.4.0 to 3.0.0 (JabRef#9259) Bump gittools/actions from 0.9.13 to 0.9.14 (JabRef#9260) Fix for resizing cleanup entries dialog (JabRef#9240) Refresh example styles Squashed 'buildres/csl/csl-locales/' changes from cb98d36691..e243665390 Squashed 'buildres/csl/csl-styles/' changes from 7bde3e4..4eee79a Fix casing Update contributing.md Remove obsolete Jekyll howto Updates Just-the-Docs from 0.3.3 to 0.4.0.rc3 (JabRef#9249) Place subgroups w.r.t. alphabetical ordering (JabRef#9228) DOAB Fetcher now fetches ISBN and imprint fields where possible (JabRef#9229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly changing an observable list to an ordinary readonly list, which is sufficient and slightly more performant.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)