Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove filter that consumes mouse rightclick #9574

Merged
merged 3 commits into from
Jan 22, 2023

Conversation

Ravitwr
Copy link
Contributor

@Ravitwr Ravitwr commented Jan 19, 2023

Fixes #9281
problem- there was a filter to consume the mouse right click mouse event which disallowed right click to select row but it allowed the context menu row creation for the row
solution- remove the filter as it is made more sense that we will be able to select row with right click also (I checked and windows explorer behaves the same way)

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 21, 2023
Siedlerchr
Siedlerchr previously approved these changes Jan 21, 2023
@Siedlerchr
Copy link
Member

Tested it. Works fine. Please add a changelog entry!°

@Ravitwr
Copy link
Contributor Author

Ravitwr commented Jan 22, 2023

Hi @Siedlerchr , I have added the changelog .

CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
groups status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Remove group" options are presented for clicked group, but actions are taken on all selected groups
3 participants