Change "database" to "catalog" #9951
Conversation
|
Hi you only need to edit the English translations, the rest is done via crowdin https://devdocs.jabref.org/code-howtos/localization.html |
Hello, thanks for your advice. I checked this website and I am confused. It seems like I need to use the function Localization.lang() when there needs to be translated, but I can't find this function be used in ManageStudyDefinition.fxml. |
|
Thanks, we will add a section on fxml, in the fxml files it's simply a % sign in front of the string |
|
Thanks for explaining it, I googled the sign % before and found nothing. |
Siedlerchr
added
the
status: ready-for-review
|
Hi, thanks for your interest in JabRef. Please note, that as long as you are not a native speaker, please remove all the language changes and leave it to crowdin to translate! Also I think the maintainers should discuss such ui changes at least in the devcall. This is maybe some fundamental discussion, if every issue in the jabref or koppor repo including an ui change is already meant to be implemented without being talked about. In this case, as this is only a very small change in the SLR subsystem, it's probably not a big deal. But nevertheless it's something to be talked about. |
calixtus
added
status: changes required
calixtus
removed
the
status: ready-for-review
There was a problem hiding this comment.
The PR is a good start. The intention, however, was to go through all the code in the slr code.
Example:
ManageStudyDefinitionView.java
I double checked the issue description - and it was also contained there. I think, you implemetned the first part. Please also implement the second part:
| @@ -231,7 +231,7 @@ | |||
| resizable="false"/> | |||
| <TableColumn | |||
| fx:id="databaseColumn" | |||
There was a problem hiding this comment.
This variable also needs to renamed
| <ScrollPane | ||
| fitToWidth="true" | ||
| fitToHeight="true" | ||
| styleClass="slr-tab"> | ||
| <VBox spacing="20.0"> | ||
| <Label text="%Select Databases:"/> | ||
| <Label text="%Select Catalogs:"/> | ||
| <HBox alignment="CENTER_LEFT"> | ||
| <TableView | ||
| fx:id="databaseTable" |
There was a problem hiding this comment.
This variable also needs to be renamed
|
Hi, sorry for that. But I don't sure what is "in SLR code". Is that mean I also change the name of related function? |
|
I try to unzip the following comment:
The "secret" is to search for "database" in the code:
Go through all classes in package
Finally, you need to modify all classes in package
This excercise will teach you how to refactor code in a learning-by-doing way. |
|
Thanks for explanation, I will go and check those code step by step |
…ogic.crawler (Issue JabRef#9951)
|
The code changes were done in #9989. I think/hope, they are done all. |
…c.crawler (#9989) * Fix for issue 615 * Add missing key pair English file * Delete translation in non-english file * We changed database to catalog in org.jabref.gui.slr and org.jabref.logic.crawler (Issue #9951) * Made required changes --------- Co-authored-by: wy8881 <wy7382@gmail.com> Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
|
The code changes were integerated in #9989 and merged in main. Thank you for your work and timely reaction on the comments! |
Fixes JabRef#615
Rename "database" to "catalog" for ul and I10n
Change the corresponding translation for some languages
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)