Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with tags #37

Closed
kuz-z-zma opened this issue Jun 22, 2024 · 7 comments
Closed

Issues with tags #37

kuz-z-zma opened this issue Jun 22, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@kuz-z-zma
Copy link

kuz-z-zma commented Jun 22, 2024

Found a bug:
If tag to be added to note contains ! or _ (maybe other special characters too) & is separated by the "," from other tags - note files won't be deleted from the monitored folder after import.
If such tag is left without "," after it - notes will be deleted, but this tag won't be added.

This results in repeated import of the same notes over and over again (with every change of settings and every newly added file to the directory).

experiments_hotfolder.log

@JackGruber
Copy link
Owner

I cannot reproduce this and not all settings are currently logged.
Could you add a screenshot of the Hotfolder settings or install the attached Plugin manual and post the logfile after a test again.

io.github.jackgruber.hotfolder.zip

@kuz-z-zma
Copy link
Author

Sure, here you go.

Win10 x64
Joplin 2.14.22 (prod, win32)

Sync Version: 3
Profile Version: 46
Keychain Supported: Yes
Revision: e579eb9

Backup: 1.4.1
Delete folder & notes: 1.1.1
Delete unlinked resources: 1.0.0
Hotfolder: 1.2.0
Note Rename: 1.0.0
Search & Replace: 2.2.0
Tagging: 1.0.3

experiments_hotfolder.log

Below are screenshots for Settings and tags, as they got mentioned in log.

As log gives an error for a tag - I did some further experiments with different tags (!!! and !_todo, they are listed later in the log)
Those are my current tags, for reference:
Screenshot_Joplin_2024-06-22-13 50 19

Four versions of setting I've used and their effect on tags for the note created.

Screenshot_Joplin_2024-06-22-13 25 19
Screenshot_Joplin_2024-06-22-13 26 44
Screenshot_Joplin_2024-06-22-13 27 32
Screenshot_Joplin_2024-06-22-13 27 53

@JackGruber
Copy link
Owner

The query in Joplin for inbox or !_imported tag returns multiple tags ...
Were notes and tags imported from Evernote or somewhere else?

@JackGruber JackGruber added the bug Something isn't working label Jun 22, 2024
@kuz-z-zma
Copy link
Author

kuz-z-zma commented Jun 22, 2024

Notes were imported from Vivaldi browser (as .md files without any tags) - upon import they were manually assigned !_imported in Joplin.
I think error is caused by my previous experiments with special characters - I've tried to rename this tag to "! imported" or "!imported" in attempts to get deletion working.

inbox I've added in Joplin to combat inability to use desired tag with an "!_" prefix.

But as you can see later, when i'm using other tags with ! in them - I get the same problem of non-deletion, only this time the error is
[error] Error: Missing "query" parameter

if I leave just inbox - everything is working as expected, regardless of having comma at the end or not

@JackGruber
Copy link
Owner

[error] Error: Missing "query" parameter

This was a error in the quick and dirty added logging ...

Could you try the following build
io.github.jackgruber.hotfolder.zip

@kuz-z-zma
Copy link
Author

Tested: now !_imported is added as tag.

test_hotfolder.log

As you can see, I've tried to switch tags around - and if list of tags to add is ending with a comma - file is not deleted.
But it works if there is no comma closing the last tag.

JackGruber added a commit that referenced this issue Jun 22, 2024
@JackGruber
Copy link
Owner

Two bugs have been fixed and will be published in the next release.

  • Tagging did not work if several tags in Joplin started the same as the tag that should be added
  • If the tag list contains several , or ends with a , an attempt tag was tried to add which resulted in a error on stop of the import function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants