Assignment2 #3
Open
Assignment2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereator
reviewed
Nov 23, 2020
| @@ -46,6 +48,8 @@ class CScene | |||
| void add(const ptr_camera_t pCamera) | |||
| { | |||
| // --- PUT YOUR CODE HERE --- | |||
| m_vpCameras.push_back(pCamera); | |||
| m_activeCamera = m_activeCamera + 1; | |||
There was a problem hiding this comment.
This is valid approach, but only in case, when you initialize m_activeCamera to be equal to -1 on construction. This also requires to have m_activeCamera variable of type int, not size_t.
How it is implemented now, it shows an error on execution.
| if (pPrim->intersect(ray)) { | ||
| hit = true; | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
This is obviously wrong. You return false all the time - so nothing can be rendered! Did you even check any results?
| @@ -87,7 +105,8 @@ class CScene | |||
| Vec3f RayTrace(Ray& ray) const | |||
| { | |||
| // --- PUT YOUR CODE HERE --- | |||
| return Vec3f(); | |||
| //return Vec3f(); | |||
| return intersect(ray) ? ray.hit->getShader()->shade(ray) : m_bgColor; | |||
| } | |||
There was a problem hiding this comment.
getShader() causes error here, because you never initialize ray.hit in the intersection algorithms
| @@ -27,7 +27,44 @@ class CShaderPhong : public CShaderFlat | |||
| virtual Vec3f shade(const Ray& ray) const override | |||
| { | |||
| // --- PUT YOUR CODE HERE --- | |||
| return RGB(0, 0, 0); | |||
| //return RGB(0, 0, 0); | |||
There was a problem hiding this comment.
Phong images are too dark
No shadows are rendered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.