make-up eyden-tracer-04 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't implement CSolidGeosphere class completely, but I tried to adjust the code from the link I mentioned in comments. For Phong Shader with bump mapping procedure, I just adjusted CShaderPhong, but did not change the name. Also, I tried to use ground.obj to test it, but unfortunately, was not successful.
I could not implement CGeosphere, but please find attached rendered images with normal sphere as was asked in the original assignment.
ereator
reviewed
Dec 24, 2020
There was a problem hiding this comment.
- GeoSphere was not implemented
- You are rendering cone made of quads and cone made of triangles on top of each other. The for loop where you add the quads should not be there. To achieve better smoothness, you need more subdivisions, so you can increase the number of sides
- No explanations in Problem 2 (-3)
- In problem 3, no textures for geosphere.
| @@ -133,11 +133,13 @@ class CScene | |||
| return intersect(ray) ? ray.hit->getShader()->shade(ray) : m_bgColor; | |||
| } | |||
|
|
|||
| public: | |||
| std::vector<ptr_light_t> m_vpLights; | |||
There was a problem hiding this comment.
You need no light for this assignment... Why?
|
|
||
| private: | ||
| Vec3f m_bgColor; ///< background color | ||
| std::vector<ptr_prim_t> m_vpPrims; ///< primitives | ||
| std::vector<ptr_light_t> m_vpLights; ///< lights | ||
| //std::vector<ptr_light_t> m_vpLights; ///< lights |
There was a problem hiding this comment.
This class should not be modified!
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I could not found where you add primitives...
| const Vec3f top(0, height, 0); // The top point | ||
| Vec3f dir0(1, 0, 0); // Initial direction | ||
| Vec3f p0 = origin + radius * dir0; // Initial point | ||
| float height_segments = sides / 12; |
There was a problem hiding this comment.
The use of height segments was not required by the assignment
| float h0 = 0; | ||
| for (int h = 0; h < height_segments - 1; h++) { | ||
| float h1 = static_cast<float>(h + 1) / height_segments; | ||
| add(std::make_shared<CSolidQuad>(pShader, |
There was a problem hiding this comment.
Using quads was not required by the assignment. Here it leads to the errors of smoothness
| Vec3f specularColor = m_ks * RGB(1, 1, 1); // white highlight; | ||
| res += (specularColor * powf(cosLightReflect, m_ke)).mul(lightIntensity.value()); | ||
| } | ||
| for(int i = 0; i < nAreaSamples; i++) { |
There was a problem hiding this comment.
Why did you incorporated area samples here ? Is it a copy-paste from last year assignments ?
In this assignment it is not needed at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not implement CGeosphere, but I implemented CSphere instead to get rendered all three objects on image. For bump mapping Phong shader, I could not complete the task, and I just modified the CShaderPhong, but did not change the name.
Worked in group with Eliza Checiu.