Assignment #6 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereator
reviewed
Dec 29, 2020
|
|
||
| // virtual void setPosition(const Vec3f& pos) override { pos = m_target; } | ||
|
|
||
| virtual void setTarget(const Vec3f& target) { m_target = target; } |
There was a problem hiding this comment.
You need to update direction also here
|
|
||
| virtual void setTarget(const Vec3f& target) { m_target = target; } | ||
|
|
||
| Vec3f getTarget(void) const { return m_target; } |
There was a problem hiding this comment.
You also need to override method setPosition() because it affects direction of the target camera
| Mat moonTransform = Mat::eye(4, 4, CV_32FC1); | ||
|
|
||
| CTransform T; | ||
| Mat earthTransform = transform.rotate(Vec3f(0.399f, 0.917, 0), 360.0f / nFrames).get(); |
There was a problem hiding this comment.
From where did you take these numbers? What does they mean?
| @@ -127,8 +126,10 @@ Mat RenderFrame(void) | |||
|
|
|||
| // --- PUT YOUR CODE HERE --- | |||
| // Apply transforms here | |||
| Mat rotationAroundTheSun = Mat::eye(4, 4, CV_32FC1); | |||
| Vec3f earthPivot = earth.getPivot(); | |||
| Mat rotationAroundTheSun = transform.translate(earthPivot).rotate(Vec3f(0, 1, 0), 1.0f / nFrames).translate(-earthPivot).get(); | |||
There was a problem hiding this comment.
What does 1.0f / nFrames mean? How did you achieve this formula?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.