QA-15289: GraphQL JCRSite query with restricted home page #464
+106
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gracefully handle scenarios where the home page has restricted access by returning null for the homePage field of the GraphQL JCRSite query.
9 tasks
…ot correctly handle here
baptistegrimaud
commented
Oct 3, 2024
| @@ -46,7 +47,9 @@ static DXPaginatedData<GqlGroup> getGroupMembership(String localPath, | |||
|
|
|||
| List<String> paths = groupManagerService.getMembershipByPath(localPath); | |||
| Stream<GqlGroup> stream = paths.stream() | |||
| .map(path -> groupManagerService.lookupGroupByPath(path).getJahiaGroup()) | |||
| .map(groupManagerService::lookupGroupByPath) | |||
There was a problem hiding this comment.
lookupGroupByPath() can return null (if the group does not exist anymore).
In the new test (site.cy.ts), a new site is created which also creates a new group for it.
And because groupManagerService.getMembershipByPath(localPath) gets the list from a cache (which for some reasons is not flushed when the site is deleted), it's returning a group that no longer exists.
Which was causing an existing test to fail (user.cy.ts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/QA-15289
Description
Gracefully handle scenarios where the home page has restricted access by returning
nullfor thehomePagefield of the GraphQL JCRSite query.Depends on #465.
Tests
The following are included in this PR
Checklist
I have considered the following implications of my change:
Documentation