BACKLOG-23333: Pack from dist/build/ and deploy dist/*.tgz #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
jkevan
approved these changes
Nov 8, 2024
baptistegrimaud
deleted the
BACKLOG-23333-use-dist-folder-for-generated-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/BACKLOG-23333
Description
Packing
Update the
pack-project.jsscript (used byyarn build) to pack the content of thedist/build/folder into adist/<project>-<version>.tgzfile.If the
dist/buildfolder does not exist, fallback to the previous behaviour and pack the root directory directly. This way, we can first release a new version of@jahia/scriptsthat we can then use in https://github.com/Jahia/luxe-jahia-demo, https://github.com/Jahia/npm-create-module, etc.Deploying
Similarly, update the
deploy.jsscript (used byyarn deployandyarn watch) to deploy thedist/<project>-<version>.tgzfile ifdist/build/exists. Otherwise, it expects the archive file in the root folder of the project.