Renamed self to window since we're in a browser environment and want to support jsdom/jsdomify

[niftylettuce]

Closes #238

[niftylettuce]

Looks like tests fail because of iframes or something?

Unsafe JavaScript attempt to access frame with URL about:blank from frame with URL

[mislav]

Sorry, but self was used to enable this polyfill working in a web worker environment.

We're sorry that you're having problems with jsdom/jsdomify, but we can't help you with that. Our polyfill works quite fine when loaded normally onto the page with <script src> tags. If your tools can't handle normal js files, maybe it's time to revisit your tools?

[mislav]

Also see #231 #47 #31

[niftylettuce]

Is there not a way you can ensure a fallback instead of self? Why can't you? This doesn't seem right. Otherwise I have to rely on my fork to get my tests to pass for https://github.com/niftylettuce/frisbee.

[niftylettuce]

if (typeof window === 'object') self = window;?

[niftylettuce]

It really doesn't make sense to me to use self JUST to make your tests pass. That's not right.

[niftylettuce]

@mislav yeah I have to stop using jsdomify and run it per jsdom/jsdom#1203 (comment) and just use pure jsdom with proper window environment.

[niftylettuce]

ignore this PR.

[mislav]

Is there not a way you can ensure a fallback instead of self? Why can't you? This doesn't seem right.

We welcome a PR that solves the compatibility issue you're describing in an elegant way while at the same time preserving compatibility with Web Workers. The existing CI test suite must pass.