Use CORS compatible domain in example #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The example URL is just for demonstration purposes only. It doesn't really matter what the exact URL is. People are to substitute their own URL in this field. The URL |
|
Shouldn't the example at least work if someone copies and pastes it? |
|
You're right! |
|
/cc #280 |
|
@dgraham Ah, thanks for that bit of context. @vga- It would have been helpful to me if you linked to the prior discussion when opening the PR. More context around the proposed change always helps! |
|
Okay, thanks! I'll make sure to do that in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes example to use api.github.com rather than github.com