added timeout support

[Gcaufy]

it's really useful to add a timeout option.

[mislav]

Thanks, but we can't accept a feature that's not in the spec! See https://github.com/github/fetch#read-this-first and #175 (comment) #405 #246 #181 #68 #16 for background.

[Gcaufy]

ok, got it.

[fritx]

Excuse me, how could we increase timeout to Infinity or over 120s which is default value of Chrome?

I couldn't find out a solution from those issues :/

---

Do I have to switch to axios or other libs to do the fetch?

PS: whatwg/fetch#20 (comment)

[Gcaufy]

@fritx
you can use Promise.race instead.

const fetchTimeout = (p, time) => {
    let timeout = new Promise((resolve, reject) => { 
        setTimeout(() => reject(new Error('timeout')), time); 
    });
    return Promise.race([p, timeout]);
};


fetchTimeout(fetch({}), 3000).then()

[fritx]

@Gcaufy your code looks like to declare a timeout instead, but I want to drop any timeout that would exist. Am I missing something?

[Gcaufy]

this is like

axios({timeout: 3000})

so I guess what you need is

axios.defaults.timeout = 3000

or a common call back, like:

fetch.globalTimeoutCallback = () => {
   console.log('this is timeout');
}

what ever you need, you can use Promise.race get what you want:
e.g.

const reqest = (p, time = null) => {
   time = time || fetch.defaults.timeout;
   if (!time) return p;
   let timer;
   let timePromise = new Promise((resolve, reject) => {
     timer = setTimeout(() => {
        fetch.globalTimeoutCallback();
        reject(new Error('timeout'));
    }, time)
   });
   return Promise.race([p.then(res => {
        clearInterval(timer);
        return res;
    ), timer])
}

[jimmywarting]

actually, this is what you should be doing:

const controller = new AbortController()
const signal = controller.signal
setTimeout(() => { 
  controller.abort()
}, 1000)

fetch(url, { signal })