MSR Read

[Shuzhengz]

Reads information from the MSR registries
Also reads current CPU and GPU TDP if used correctly
Closes #41 #131

[Shuzhengz]

tiny problem
use of unstable library feature 'asm': inline assembly is not stable enough for use and is subject to change

[JakeRoggenbuck]

Thanks for going after this one!

[Shuzhengz]

yee

[Shuzhengz]

but yeah if we solve this asm problem we will be able to use it to read MSR, and we can get TDP, GPU TDP, clockspeed, max temp target, and potentially undervolting

[Shuzhengz]

@JakeRoggenbuck okay heres the big brain idea, what if we read from MSR in C, then export the values to rust

[JakeRoggenbuck]

MSR

Yea! Does an MSR exist for rust? If not, we could make that library then use it as a dependency in case someone else needs MSR as well.

[JakeRoggenbuck]

This is a thing, not sure if it's the right thing, or the best thing https://docs.rs/x86_64/0.1.2/x86_64/registers/msr/index.html

We can always use our own if it's easier and more efficient

[Shuzhengz]

MSR

Yea! Does an MSR exist for rust? If not, we could make that library then use it as a dependency in case someone else needs MSR as well.

Yeah rust does have a MSR library, but it cannot be used in production because asm is nightly and development only

I tried to make a read msr function but it also doesn't build due to unstable inline assembly

[Shuzhengz]

This is a thing, not sure if it's the right thing, or the best thing https://docs.rs/x86_64/0.1.2/x86_64/registers/msr/index.html

We can always use our own if it's easier and more efficient

Yeah I tried to use that one, but the entire core::arch::asm is not available and the library doesn't build properly with our project

[Shuzhengz]

dat's why I said it might be a good idea to read it in c cuz intel actually gives the method to read from MSR in c

[Shuzhengz]

asm is still not stablize enough to be used, stablization PR not made

ill try using C/C++ and see if it works

[JakeRoggenbuck]

Great work with this! Looks super good

[JakeRoggenbuck]

This is going to be a great addition to acs

[Shuzhengz]

Thx!
I'm still trying to verify if the thing actually works tho, and I haven't integrated it with rust yet

[Shuzhengz]

The documentation on this is... well, intel didn't even bother to make a readme for it

[JakeRoggenbuck]

The documentation on this is... well, intel didn't even bother to make a readme for it

Ooof, we might be able to help them out and write some docs for this, and then give it to them lol

[Shuzhengz]

well... yea...

[JakeRoggenbuck]

Lol, yea, that's a little while ago

[JakeRoggenbuck]

Seven years before GitHub was created

[Shuzhengz]

this code is older than anyone here lol

[Shuzhengz]

ayyy got reading msr in hex working in c

[Shuzhengz]

probably work on this a later time when we can use asm outside of experimental