Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All nerdfont icons used in ironbar break with new version of nerdfont #152

Closed
yavko opened this issue May 17, 2023 · 6 comments · Fixed by #155 or #389
Closed

All nerdfont icons used in ironbar break with new version of nerdfont #152

yavko opened this issue May 17, 2023 · 6 comments · Fixed by #155 or #389
Labels
bug Something isn't working
Milestone

Comments

@yavko
Copy link
Contributor

yavko commented May 17, 2023

Describe the bug

Yeah so the nerdfont devs released a new release (0.3.0), and now all the icons don't work (appear as CJK or Arabic) :) ryanoasis/nerd-fonts#365
https://www.nerdfonts.com/releases

To Reproduce
Steps to reproduce the behavior:

  1. update nerdfont
  2. see

Expected behavior

Icons aren't CJK or Arabic

System information:

  • Distro: NixOS unstable
  • Compositor: Hyprland
  • Ironbar version: master

Screenshots
image

play button is fine cuz i overwrote that one with system icon theme

image

song title should be cjk here, but first chars are brokey

@yavko yavko added the bug Something isn't working label May 17, 2023
@yavko
Copy link
Contributor Author

yavko commented May 17, 2023

btw https://github.com/loichyan/nerdfix can help, used it for my dotfiles, and has a nice tui with autocomplete

@JakeStanger
Copy link
Owner

Correct me if I'm wrong, but I don't think this is in scope of ironbar (outside the docs), since it doesn't handle fonts beyond loading the CSS styles.

I'll look to see if/how this affects the examples and update those.

@yavko
Copy link
Contributor Author

yavko commented May 18, 2023

Correct me if I'm wrong, but I don't think this is in scope of ironbar (outside the docs), since it doesn't handle fonts beyond loading the CSS styles.

I'll look to see if/how this affects the examples and update those.

It is, the Unicode values have changed

@yavko
Copy link
Contributor Author

yavko commented May 18, 2023

If you update your fonts you will see this too, problem is with the defaults

@JakeStanger
Copy link
Owner

It is, the Unicode values have changed

Ah of course, I forgot there are chars coded into the defaults 🤦 I'm with you now

@JakeStanger JakeStanger added this to the 0.12.1 milestone May 18, 2023
JakeStanger added a commit that referenced this issue May 21, 2023
@JakeStanger
Copy link
Owner

Think that's got 'em. From memory / a quick search I don't think there are any outside of the music module, and nerdfix didn't find anything else. Let me know if you know there's anything I've missed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants