Skip to content
This repository has been archived by the owner on Apr 19, 2018. It is now read-only.

NineOldAndroids doesn't work with Build Tools 22 #80

Open
serso opened this issue Apr 9, 2015 · 1 comment · May be fixed by #81
Open

NineOldAndroids doesn't work with Build Tools 22 #80

serso opened this issue Apr 9, 2015 · 1 comment · May be fixed by #81

Comments

@serso
Copy link

serso commented Apr 9, 2015

Build Tools 22 removes attributes targeted to higher versions of Android from xml file, copying the original file to an appropriate bucket. On lower versions of Android (f.e. 9) NineOldAndroids can't access such attributes (as they are now in animator-vXX bucket) and crashes.

Build Tools commit which breaks NineOldAndroids: https://android.googlesource.com/platform/frameworks/base/+/28994d8d181c286b39811441ce78399576c2d315%5E%21/#F0
@serso
Copy link
Author

serso commented Apr 9, 2015

Possible workarounds:

  1. Use Build Tools v. 21
  2. Create animators in the code instead of inflating them from xml files

serso added a commit to serso/NineOldAndroids that referenced this issue Apr 11, 2015
@serso
Animators defined in XMLs should work with Build Tools 22
0f21c44 
Problem: Build Tools 22 removes attributes targeted to higher
versions of Android from xml file, copying the original
file to an appropriate bucket. On lower versions of
Android (f.e. 9) NineOldAndroids can't access such
attributes (as they are now in animator-vXX bucket) and crashes.

Solution: let's use our own custom attributes instead of
Android attributes. All XMLs defining animators should be changed -
project namespace should be used instead of Android one.

Fixes JakeWharton#80
@serso serso linked a pull request Apr 11, 2015 that will close this issue
Open
@AlbertGrobas AlbertGrobas mentioned this issue May 13, 2015
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Animators defined in XMLs should work with Build Tools 22 serso/NineOldAndroids
1 participant
@serso