enable logging by delegation #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solves the same problem as #362. Both target the new Timber API (5.x) which unfortunately hasn't seen any action in a year or so. |
This was referenced Dec 12, 2019
ll08121826
approved these changes
Dec 14, 2019
hannesa2
force-pushed
the
EnableLoggingByDelegation
branch
from
211bd84
to
fbe7a1c
Compare
hannesa2
force-pushed
the
EnableLoggingByDelegation
branch
from
fbe7a1c
to
ecb7ff5
Compare
hannesa2
force-pushed
the
EnableLoggingByDelegation
branch
from
ecb7ff5
to
c0e2ddb
Compare
hannesa2
force-pushed
the
EnableLoggingByDelegation
branch
from
c0e2ddb
to
cf94ad7
Compare
hannesa2
force-pushed
the
EnableLoggingByDelegation
branch
3 times, most recently
from
c509e48
to
7a942ba
Compare
hannesa2
force-pushed
the
EnableLoggingByDelegation
branch
from
7a942ba
to
1be7193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have to use Timber with a delegator, currently you log just the delegator class. -sad-
Or when you change logging tool just in one place and do not change every log call in code (this can be very easy > 1000 places), you probably need a delegator.
With this PR you can solve this (in my point of view) elegant