Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom function to generate tag id #89

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

niklashempel
Copy link
Contributor

@niklashempel niklashempel commented Aug 26, 2024

This PR solves #88

Copy link

vercel bot commented Aug 26, 2024

@niklashempel is attempting to deploy a commit to the jaleelb's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@JaleelB JaleelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emblor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 2:04pm

@JaleelB
Copy link
Owner

JaleelB commented Aug 28, 2024

Before I merge this in, do the following:

  • update the docs on the API references page under docs/content. There is an api-reference mdx page that contains the contain for the API reference page
  • run pnpm run format to format the code so the type-check job in the code check action passes

@niklashempel
Copy link
Contributor Author

Done. I also updated the snippet in tag-input.mdx

Copy link
Owner

@JaleelB JaleelB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaleelB JaleelB merged commit 07071f9 into JaleelB:main Aug 29, 2024
2 of 3 checks passed
@JaleelB JaleelB linked an issue Aug 29, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat]: Pass function to generate tag id
2 participants