Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better folding #985

Merged
merged 3 commits into from
Nov 15, 2018
Merged

Better folding #985

merged 3 commits into from
Nov 15, 2018

Conversation

James-Yu
Copy link
Owner

@James-Yu James-Yu commented Nov 14, 2018

This aims to resolve some new minor issues when the indentation-based folding was replaced by a handicraft folding logic @neilsustc. The new PR makes use of stacks to store env folding, and a line number list to handle section nestings. The env stack part was contributed by @iamhyc #984.

@neilsustc @Astrantia Please take a look.

@James-Yu
Copy link
Owner Author

Quite interestingly, @iamhyc 's implementation is quite javascript-ish, while mine is old-fashioned loop-in-loop-in-loop. Refactoring my part is welcomed for anyones OCD's sake.

@yzhang-gh
Copy link
Contributor

(I will do it if it is still not taken by someone else by this weekend 😂)

@James-Yu James-Yu merged commit dab92ea into master Nov 15, 2018
@James-Yu James-Yu deleted the folding branch November 15, 2018 02:38
@Melvasul
Copy link

Hello there(hoping that it's the right place to post because I did not want to open a new issue/feature request)

I saw that this extension lets you collapse many sections of the .tex files such as
\chapter \(sub)(sub)section \(sub)paragraph
as well as \begin{...} and so on

but not the section: \part{}
Is it possible to add it?

Thank in advance, have a nice day!

screenshot from 2018-11-18 13-17-32

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants