Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix unmarshalling ipv6 ::/0 #48

Merged
merged 1 commit into from
Oct 27, 2017
Merged

lib: fix unmarshalling ipv6 ::/0 #48

merged 1 commit into from
Oct 27, 2017

Conversation

squat
Copy link
Contributor

@squat squat commented Oct 9, 2017

If you log into Vultr console and create an IPv6 firewall rule for ::/0 then in the CLI you do:

vultr firewall rule list <firewall group ID>

you incorrectly get a IPv4 CIDR like so:

RULE_NUM        ACTION  PROTOCOL        PORT    NETWORK
1               accept  tcp             80    0.0.0.0/0

This PR fixes this issue and adds a test to validate.

@squat squat mentioned this pull request Oct 9, 2017
Closed
@squat
Copy link
Contributor Author

squat commented Oct 27, 2017

Ping @JamesClonk

@JamesClonk JamesClonk merged commit e5dad9a into JamesClonk:master Oct 27, 2017
@JamesClonk
Copy link
Owner

thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@squat @JamesClonk