fix: 🐛 Fixes an issue where informational messages are throwing errors #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1168 +/- ##
==========================================
- Coverage 98.20% 97.85% -0.36%
==========================================
Files 7 7
Lines 279 280 +1
Branches 76 76
==========================================
Hits 274 274
- Misses 5 6 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reported here #1167
Testing Instructions
You can point your workflow to
JamesIves/github-pages-deploy-action@releases/v4-stto test this.Additional Notes
If the error starts with
fatal:and it's not rejected, we throw, otherwise the message is allowed to go through.