Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buggy behaviour of tgl reports span-[offset] #79

Closed
JamesNZL opened this issue Jun 24, 2023 · 3 comments
Closed

Buggy behaviour of tgl reports span-[offset] #79

JamesNZL opened this issue Jun 24, 2023 · 3 comments
Assignees
@JamesNZL
Labels
bug Something isn't working

Comments

@JamesNZL
Copy link
Owner

JamesNZL commented Jun 24, 2023 •
edited
Loading

The -offset is sometimes included when a grouping is selected, sometimes it's completely ignored...

image
image

Both these go to tgl reports day projects, rather than the 2nd going to tgl reports day-1 projects 🙃
@JamesNZL JamesNZL added the bug Something isn't working label Jun 24, 2023
@JamesNZL JamesNZL self-assigned this Jun 24, 2023
@JamesNZL
Copy link
Owner Author

JamesNZL commented Jun 24, 2023 •
edited
Loading

https://github.com/Flow-Launcher/Flow.Launcher/blob/e1c63af06184d3993128da09373307566265e425/Flow.Launcher.Plugin/Result.cs#L162C13-L162C13

Grr... 50 minutes of debugging later 🥴

It seems like there is some internal caching that doesn't update the displayed result (and hence the AutoCompleteText and Action) if the results pass Equals.

@JamesNZL
Copy link
Owner Author

Related to Flow-Launcher/Flow.Launcher#2201 and Flow-Launcher/Flow.Launcher#2202.

@JamesNZL JamesNZL changed the title Buggy behaviour of tgl reports span[-offset] Buggy behaviour of tgl reports span-[offset] Jun 24, 2023
JamesNZL added a commit that referenced this issue Jun 24, 2023
@JamesNZL
fix(ux): 🐛 fix buggy tgl reports span-[offset] detection (#79)
6425713
@JamesNZL
Copy link
Owner Author

Fixed (with a hopefully temporary solution).

flow-toggl-plugin/src/TogglTrack.cs

Line 2154 in 6425713

Title = $"{grouping.Argument}{new string('\u200B', queryToGrouping.Length)}",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesNZL JamesNZL

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesNZL