Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make benchmark peer dependency #14

Conversation

MichaReiser
Copy link
Contributor

Make benchmark.js a peer dependency that a project might use a different version.
E.g. a version that points to a pull request.

@JamieMason
Copy link
Owner

JamieMason commented Mar 20, 2017

Ignore my previous comment, I'll give this a try after npm linking it locally.

@MichaReiser
Copy link
Contributor Author

The main reason for defining it as peer dependency is to be able to use a different version of benchmarkjs.

In my case, I need the version that has support for async setup and teardown (not yet released).

@AleshaOleg
Copy link

Are there any updates? If I'll update this PR, will somebody merge this?

@JamieMason
Copy link
Owner

I'll pick it up, thanks

@AleshaOleg
Copy link

@JamieMason npm run test cause an error: TypeError: Cannot set property 'start' of undefinedin src/main.js:14:24. Did tests work before? Because for me, after and before updating dependencies they not working.

@AleshaOleg
Copy link

Ok, I have a problem with hoek dependency in some of the packages and thought that a problem with karma-benchmark. That's why I wanted to help with package updating. I was wrong, problem in another package. Sorry.

@MichaReiser I think if you need t use @next version of npm package, you can install it manually in your package and use the latest features. And there is no need to ask somebody to install it as peerDependencies. Am I wrong?

@JamieMason
Copy link
Owner

@JamieMason npm run test cause an error: TypeError: Cannot set property 'start' of undefinedin src/main.js:14:24. Did tests work before? Because for me, after and before updating dependencies they not working.

Apologies, the tests are no good. There is one which I will remove for now. I'd love to pick this project back up and do a proper job of it but haven't had time yet.

@JamieMason JamieMason closed this in 0948dae Jul 9, 2018
@JamieMason
Copy link
Owner

Released as 1.0.0, please let me know if any changes are needed. Thanks so much for your help and sorry for the long wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants