-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make benchmark peer dependency #14
Make benchmark peer dependency #14
Conversation
Ignore my previous comment, I'll give this a try after |
The main reason for defining it as peer dependency is to be able to use a different version of benchmarkjs. In my case, I need the version that has support for async setup and teardown (not yet released). |
Are there any updates? If I'll update this PR, will somebody merge this? |
I'll pick it up, thanks |
@JamieMason |
Ok, I have a problem with @MichaReiser I think if you need t use |
Apologies, the tests are no good. There is one which I will remove for now. I'd love to pick this project back up and do a proper job of it but haven't had time yet. |
Released as 1.0.0, please let me know if any changes are needed. Thanks so much for your help and sorry for the long wait. |
Make benchmark.js a peer dependency that a project might use a different version.
E.g. a version that points to a pull request.