Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Angular 1.3 http interceptor api change #20

Merged
merged 5 commits into from
Jul 17, 2014
Merged

Fix for Angular 1.3 http interceptor api change #20

merged 5 commits into from
Jul 17, 2014

Conversation

vik-singh
Copy link

Angular 1.3 deprecated the old $http interceptor API - this change fixes the server sent notifications - New API is described here: https://docs.angularjs.org/api/ng/service/$http#interceptors

@JanStevens
Copy link
Owner

Does this brake support for angular 1.2?

@vik-singh
Copy link
Author

@JanStevens Yes - fully tested with angular 1.2.x - I believe the API was changed long before 1.2 but old API wasn't fully deprecated until 1.3.

@JanStevens
Copy link
Owner

Hello,

Finally got the time to see the changes you made. I see you made changes in the build directory instead of the src directory. The distribution is created with grunt and will overwrite any changes you made in the build directory. Can you please commit your changes to the src directory?

Thanks!

@vik-singh
Copy link
Author

I changed src/growlFactory.js - then I ran grunt and built the project and committed changes to the build directory too. So the changes were committed to src first (look at c5b5a89) - the subsequent commits were simply to build correctly.

@JanStevens
Copy link
Owner

Ha my bad! thanks for your contribution!

JanStevens pushed a commit that referenced this pull request Jul 17, 2014
Fix for Angular 1.3 http interceptor api change
@JanStevens JanStevens merged commit bf5f9d7 into JanStevens:master Jul 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants