This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
pull out decoded ID for hashedFields #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, I'm actually surprised it somehow didn't break on my own codebases (which uses objection-hashid). Thanks for the easy reproduction, I'll be sure to add test cases covering this. |
|
I will upload the fixed version to npm as soon as I can write a test for it. |
|
Sounds great, thanks @JaneJeon! |
|
It's already been uploaded to npm, so just bump your version of objection-hashid! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋
First off, thanks for the handy project. It's been great to use so far.
I noticed an issue related to the hashedFields static model property. It seemed like the hashed fields we being respected, but the decoding wasn't happening properly.
I built a project to reproduce the issue and to try out the fix. More description in the readme: https://github.com/jakeorr/objection-hashid-investigation