Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update ocis images directly in markdown content #61

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jul 15, 2024

Description

Parsing the ocis images and updating the urls directly in the markdown content and let reveal prepare the slides afterward.
Also added loading spinner until the presentation is ready to show.

How Has This Been Tested?

  • test environment: 💻 🤚

Screenshots (if appropriate):

Screenshot from 2024-07-15 16-28-04 Screenshot from 2024-07-15 16-27-35
Screenshot from 2024-07-15 16-27-38 Screenshot from 2024-07-15 16-27-41

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)
  • Documentation only (no source changes)
  • Maintenance (e.g. dependency updates or tooling)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation updated

@saw-jan saw-jan marked this pull request as ready for review July 15, 2024 10:45
@saw-jan saw-jan requested a review from S-Panta July 15, 2024 10:45
@saw-jan saw-jan changed the title refactor: parse markdown early refactor: update ocis images directly in markdown content Jul 15, 2024
@S-Panta
Copy link
Contributor

S-Panta commented Jul 16, 2024

Tested on ownCloud Web UI 9.1.0 , Infinite Scale 6.1.0 Community and it works

@saw-jan saw-jan merged commit 6f4d5e5 into main Jul 16, 2024
1 check passed
@saw-jan saw-jan deleted the refactor/parse-markdown-early branch July 16, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants