Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWSD Controls] Option to only work when holding RightMouse #577

Merged
merged 7 commits into from
Aug 24, 2024

Conversation

caioraphael1
Copy link
Contributor

@caioraphael1 caioraphael1 commented Jul 14, 2024

Overall after being edited:

  • New option to only enable the controls if the movement is enabled AND is holding the Right Mouse Button.
    • Off by default
    • Disabling the option returns to the old behavior.
  • Creation of 2 new buttons: Move Faster and Move Slower, bound to shift and alt by default, with options to change it in the settings.
  • The state of the 'WASD Toggle' tool is now saved across restarts.

image

I really like those new options, as they make the movement more in line with Blender and Godot, for example.

plugins/wasd_controls.js Show resolved Hide resolved
plugins/wasd_controls.js Outdated Show resolved Hide resolved
plugins/wasd_controls.js Outdated Show resolved Hide resolved
-> metadata in plugin.json
-> improved name for 'requires_hold_right_mouse' setting
-> set the 'requires_hold_right_mouse' to be false by default
@caioraphael1
Copy link
Contributor Author

caioraphael1 commented Jul 15, 2024

I also just made changes locally regarding:

  • Make the zoom work correctly if not pressing the Right Mouse Button while having the 'wasd_requires_hold_right_mouse' enabled.
  • Creation of 2 new buttons: Move Faster and Move Slower, bound to shift and alt by default, with options to change it in the settings.
  • Setting to modify the factor of the Move Faster and Move Slower modifiers.

I have these changes locally, but I wasn't sure if it was correct to commit them here (I haven't collaborated before)

@JannisX11
Copy link
Owner

You still need to update the name of the new setting. It will be visible in the main settings menu.
Feel free to include the other changes here as well.

@caioraphael1
Copy link
Contributor Author

caioraphael1 commented Jul 16, 2024

You still need to update the name of the new setting. It will be visible in the main settings menu. Feel free to include the other changes here as well.

Ooh, now I get it. I think now is correct.

The new changes are now on.

…e app

I don't know if the best idea, but I created a setting to save the tool state.
@caioraphael1
Copy link
Contributor Author

I also made a new change that captures the mouse while flying, so you don't click something by mistake while moving the mouse. This locks the mouse in the current position and makes it invisible. It's an experimental feature as it was made using a bunch of input overrides to avoid the default behavior. After this commit is reviewed, I think these new experimental changes could be useful, if consider creating an option to make the 'mouse capture' the default behavior for moving the camera in Blockbench as a whole.

caioraphael1

This comment was marked as resolved.

caioraphael1

This comment was marked as resolved.

@JannisX11 JannisX11 merged commit 8790f9b into JannisX11:master Aug 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants