Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leftover faces after vertex merge #2051

Conversation

farfalk
Copy link
Contributor

@farfalk farfalk commented Oct 9, 2023

As per title. The bug happens everytime you make a face "disappear" through collapsing two-by-two the vertices sorrounding it: check the video below. Ignore the "mirroring" activation: I was looking for another bug when I found this!

8mb.video-lS5-mxUAuW2L.mp4

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for blockbench-dev ready!

Name Link
🔨 Latest commit f33eed6
🔍 Latest deploy log https://app.netlify.com/sites/blockbench-dev/deploys/6524602b8948c200074f4ae2
😎 Deploy Preview https://deploy-preview-2051--blockbench-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JannisX11
Copy link
Owner

Good catch, would need to be implemented differently though. Currently this clears all 2-vertex faces from the mesh, even if they are somewhere else in the model. So this would need to check if the vertices were modified, and if the leftover edge overlaps with an existing face.

@farfalk
Copy link
Contributor Author

farfalk commented Feb 21, 2024

Good catch, would need to be implemented differently though. Currently this clears all 2-vertex faces from the mesh, even if they are somewhere else in the model. So this would need to check if the vertices were modified, and if the leftover edge overlaps with an existing face.

Sorry for the delay in responding. Just here to report that this still happens in 4.9.4.

Unfortunately I don't really know how to proceed :(

@JannisX11 JannisX11 closed this in 99e91c0 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants