Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 3D brush matrix when using groups with a rotation and translation #2595

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

Nestorboy
Copy link
Contributor

  • Reverted 067ca50 as the matrix multiplication was done too early.
  • Used the .worldMatrix from the intersected object instead of its local transform .matrix.

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for blockbench-dev ready!

Name Link
🔨 Latest commit d163194
🔍 Latest deploy log https://app.netlify.com/sites/blockbench-dev/deploys/6765cfd7ac8b9600087bb670
😎 Deploy Preview https://deploy-preview-2595--blockbench-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@JannisX11 JannisX11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@JannisX11 JannisX11 merged commit 0602e60 into JannisX11:next Dec 20, 2024
4 checks passed
@Nestorboy Nestorboy deleted the fix-3d-brush-group branch January 3, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants