Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(config-api): default value for Client attribute applicationType set #2432

Merged
merged 6 commits into from
Sep 21, 2022
Merged

docs(config-api): default value for Client attribute applicationType set #2432

merged 6 commits into from
Sep 21, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Sep 21, 2022

Prepare

Description

Target issue

closes #1658

Implementation Details

Added default value web for applicationType in https://github.com/JanssenProject/jans/blob/main/jans-config-api/docs/jans-config-api-swagger.yaml

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs pujavs requested a review from yuriyz as a code owner September 21, 2022 15:43
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pujavs pujavs changed the title Jans fixes docs(config-api): default value for Client attribute applicationType set Sep 21, 2022
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-config-api Component affected by issue or PR labels Sep 21, 2022
@yuriyz yuriyz merged commit 5ba4341 into main Sep 21, 2022
@yuriyz yuriyz deleted the jans-fixes branch September 21, 2022 16:06
@mo-auto mo-auto mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-config-api Component affected by issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEAT: CLI: Improve Interactive OpenID Connect Client Creation
3 participants
@pujavs @yuriyz @mo-auto