Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: external secrets #4552

Merged
merged 3 commits into from
Apr 18, 2023
Merged

docs: external secrets #4552

merged 3 commits into from
Apr 18, 2023

Conversation

misba7
Copy link
Contributor

@misba7 misba7 commented Apr 11, 2023

Prepare

Description

Target issue

closes #issue-number-here

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@misba7 misba7 requested a review from moabu as a code owner April 11, 2023 22:02
moabu
moabu requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@moabu moabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/GluuFederation/cloud-native-edition/pull/542/files/2be272b31c968deed743bd9a5a410097a971f159

@moabu moabu merged commit a5fcd48 into JanssenProject:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misba7 @moabu