feat(cloud-native): allow pulling SSL cert from FQDN #8320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iromli <isman.firmansyah@gmail.com>
mo-auto
added
area-documentation
moabu
approved these changes
Apr 17, 2024
yuriyz
pushed a commit
that referenced
this pull request
Nov 7, 2024
Signed-off-by: iromli <isman.firmansyah@gmail.com> Former-commit-id: 2acab07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
Description
Target issue
closes #8308
Implementation Details
Add
CN_SSL_CERT_FROM_SECRETSenv as featureflag. If set totrue, SSL cert will be pulled from existing secrets, otherwise cert will be pulled from FQDN. Note that the Helm charts uses switchisFqdnRegisteredto set the environment correctly.Test and Document the changes