Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(agama): refactor agama to use acr_values instead of agama_flow #8354

Merged
merged 3 commits into from
Apr 20, 2024
Merged

chore(agama): refactor agama to use acr_values instead of agama_flow #8354

merged 3 commits into from
Apr 20, 2024

Conversation

jgomer2001
Copy link
Contributor

Prepare

Description

Target issue

closes #8228

See #8216

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@jgomer2001
docs: update documentation to conform changes #8228
c22dca3 
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
@jgomer2001
chore: refactor agama to use data in acr_values #8228
d49b0e8 
Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR comp-agama Touching folder /agama kind-dependencies Pull requests that update a dependency file labels Apr 19, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yuriyz yuriyz merged commit 1b6bb3e into main Apr 20, 2024
2 checks passed
@yuriyz yuriyz deleted the agama-issue_8228 branch April 20, 2024 16:35
yuriyz added a commit that referenced this pull request Nov 7, 2024
@jgomer2001 @yuriyz
chore(agama): refactor agama to use acr_values instead of agama_flow (#…
f2b8e6d 
…8354)

* docs: update documentation to conform changes #8228

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>

* chore: refactor agama to use data in acr_values #8228

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>

---------

Signed-off-by: jgomer2001 <bonustrack310@gmail.com>
Co-authored-by: YuriyZ <yzabrovarniy@gmail.com>
Former-commit-id: 1b6bb3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devrimyatar devrimyatar devrimyatar approved these changes

@yuriyz yuriyz yuriyz approved these changes

@yurem yurem Awaiting requested review from yurem yurem is a code owner

@yuriyzz yuriyzz Awaiting requested review from yuriyzz yuriyzz is a code owner

Assignees
No one assigned
Labels
area-documentation Documentation needs to change as part of issue or PR comp-agama Touching folder /agama comp-jans-auth-server Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(agama): refactor agama to use acr_values instead of agama_flow
4 participants
@jgomer2001 @yuriyz @devrimyatar @mo-auto