Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-pycloudlib): handle rdbm_json_column in schema definitions #8359

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Apr 20, 2024

Prepare


Description

Target issue

closes #8358

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: iromli <isman.firmansyah@gmail.com>
@mo-auto mo-auto added comp-jans-pycloudlib kind-feature Issue or PR is a new feature request labels Apr 20, 2024
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@1b6bb3e). Click here to learn what that means.

❗ Current head 9cf11bc differs from pull request most recent head c667598. Consider uploading reports for the commit c667598 to get more accurate results

Files Patch % Lines
jans-pycloudlib/jans/pycloudlib/persistence/sql.py 36.36% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8359   +/-   ##
=======================================
  Coverage        ?   60.23%           
=======================================
  Files           ?       36           
  Lines           ?     3189           
  Branches        ?        0           
=======================================
  Hits            ?     1921           
  Misses          ?     1268           
  Partials        ?        0           
Flag Coverage Δ
unittests 60.23% <36.36%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iromli iromli marked this pull request as ready for review April 21, 2024 09:07
@iromli iromli requested a review from moabu as a code owner April 21, 2024 09:07
@iromli iromli marked this pull request as draft April 22, 2024 06:07
Signed-off-by: iromli <isman.firmansyah@gmail.com>
Copy link

sonarcloud bot commented Apr 22, 2024

@iromli iromli marked this pull request as ready for review April 22, 2024 06:47
@moabu moabu merged commit 19f0deb into main Apr 22, 2024
4 checks passed
@moabu moabu deleted the cn-pycloudlib-json branch April 22, 2024 09:00
yuriyz pushed a commit that referenced this pull request Nov 7, 2024
…8359)

* feat(jans-pycloudlib): handle rdbm_json_column in schema definitions

Signed-off-by: iromli <isman.firmansyah@gmail.com>

* fix(jans-pycloudlib): handle data type while parsing data from LDIF file

Signed-off-by: iromli <isman.firmansyah@gmail.com>

---------

Signed-off-by: iromli <isman.firmansyah@gmail.com>
Former-commit-id: 19f0deb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-pycloudlib kind-feature Issue or PR is a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(jans-pycloudlib): handle rdbm_json_column in schema definitions
3 participants