Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jans-casa): bioid plugin fixes #8410

Merged
merged 3 commits into from
Apr 29, 2024
Merged

chore(jans-casa): bioid plugin fixes #8410

merged 3 commits into from
Apr 29, 2024

Conversation

SafinWasi
Copy link
Contributor

Prepare


Description

Target issue

Closes #8404 and closes #8405

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR kind-dependencies Pull requests that update a dependency file labels Apr 29, 2024
@SafinWasi
Copy link
Contributor Author

UI change:

image

@moabu moabu merged commit d3df15e into main Apr 29, 2024
2 checks passed
@moabu moabu deleted the chore-bioid-changes branch April 29, 2024 17:30
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed for 'jans-core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

yuriyz pushed a commit that referenced this pull request Nov 7, 2024
* chore(jans-casa): fix bioid menu item

Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>

* docs(jans-casa): add link to bioid page

Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>

---------

Signed-off-by: SafinWasi <6601566+SafinWasi@users.noreply.github.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Former-commit-id: d3df15e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR kind-dependencies Pull requests that update a dependency file
Projects
None yet
4 participants