Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-cli-tui): principalAttribute and principalType for SAML TR #8538

Merged
merged 2 commits into from
May 22, 2024
Merged

fix(jans-cli-tui): principalAttribute and principalType for SAML TR #8538

merged 2 commits into from
May 22, 2024

Conversation

devrimyatar
Copy link
Contributor

@devrimyatar devrimyatar commented May 19, 2024 •
edited by mo-auto
Loading

closes #8384
Closes #8539,

@devrimyatar
fix(jans-cli-tui): principalAttribute and principalType for SAML TR
9247413 
Signed-off-by: Mustafa Baser <mbaser@mail.com>
@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-cli-tui Component affected by issue or PR labels May 19, 2024
@devrimyatar devrimyatar requested review from yuriyz and pujavs May 19, 2024 13:19
@mo-auto
Copy link
Member

mo-auto commented May 19, 2024

Error: Hi @devrimyatar, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@mo-auto mo-auto mentioned this pull request May 19, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 19, 2024

Quality Gate Passed Quality Gate passed for 'jans-cli'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yuriyz yuriyz enabled auto-merge (squash) May 20, 2024 10:02
@yuriyz yuriyz merged commit 5ab54ac into main May 22, 2024
1 of 2 checks passed
@yuriyz yuriyz deleted the jans-cli-tui-idp-fields branch May 22, 2024 08:33
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed for 'jans-config-api-parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

yuriyz pushed a commit that referenced this pull request Nov 7, 2024
@devrimyatar
fix(jans-cli-tui): principalAttribute and principalType for SAML TR (#…
5d30b76 
…8538)

Signed-off-by: Mustafa Baser <mbaser@mail.com>
Former-commit-id: 5ab54ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pujavs pujavs pujavs approved these changes

@yuriyz yuriyz yuriyz approved these changes

Assignees
No one assigned
Labels
comp-jans-cli-tui Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
4 participants
@devrimyatar @mo-auto @yuriyz @pujavs