fix: charts java memory options passed #8564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
mo-auto
added
comp-charts-jans
kind-bug
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
Signed-off-by: moabu <47318409+moabu@users.noreply.github.com>
|
@moabu we're lowering the memory allocation almost 50% as seen below (for example): env:
- name: CN_SCIM_JAVA_OPTIONS
value: "-XX:MaxDirectMemorySize=492m -Xmx612m"
resources:
limits:
cpu: 1000m
memory: 1200Mi
requests:
cpu: 1000m
memory: 1200Mi |
iromli
approved these changes
May 27, 2024
yuriyz
pushed a commit
that referenced
this pull request
Nov 7, 2024
* fix: memory options Signed-off-by: moabu <47318409+moabu@users.noreply.github.com> * fix: use percentages Signed-off-by: moabu <47318409+moabu@users.noreply.github.com> * fix: use mulf for floats percentages Signed-off-by: moabu <47318409+moabu@users.noreply.github.com> --------- Signed-off-by: moabu <47318409+moabu@users.noreply.github.com> Former-commit-id: 4226f2a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare
Description
Target issue
closes #8563