Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-api): added asset validation and pagination, removed redundant fields for TR, agama swagger spec #8582

Merged
merged 33 commits into from
May 24, 2024

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented May 24, 2024

Prepare


Description

Issue#8541: fix: add validation for asset mgt module
Issue#8549: feat(config-api): implement pagination for asset mgt
Issue#8572: bug(config-api): SAML TR - remove non-required fields
Issue#8581: doc(config-api): agama doc add missing doc parameter description

Target issue

closes #8541 #8549 #8572 #8581

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…thentication issue#8384

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
…d service validation

Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
Signed-off-by: pujavs <pujas.works@gmail.com>
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels May 24, 2024
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed for 'jans-core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yuriyz yuriyz enabled auto-merge (squash) May 24, 2024 17:26
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yuriyz yuriyz merged commit d36fc80 into main May 24, 2024
1 of 2 checks passed
@yuriyz yuriyz deleted the jans-config-fix branch May 24, 2024 19:07
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed for 'Jans-Keycloak-Link'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 24, 2024

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed for 'Fido2 API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed for 'SCIM API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

yuriyz pushed a commit that referenced this pull request Nov 7, 2024
…dant fields for TR, agama swagger spec (#8582)

* fix(config-api): user attribute validation error handling

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): user attribute validation error handling

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): user attribute validation error handling

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix: added new IDP attributes

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix: added new IDP attributes

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): idp default values set

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): idp metadata default values issue#8384

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat: idp metadata default value and removing filepath in document-store

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat: idp metadata default value and removing filepath in document-store

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix: assetmgt and idp changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix: assetmgt and idp changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): validation for imp fields of asset mgt

Signed-off-by: pujavs <pujas.works@gmail.com>

* feat(config-api): pagination for get asset by name, asset filename and service validation

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): added asset validation, removed redundant fields for TR

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): agama swagger spec changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): agama swagger spec changes

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): added asset validation, removed redundant fields for TR

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): added asset validation, removed redundant fields for TR

Signed-off-by: pujavs <pujas.works@gmail.com>

* fix(config-api): added asset validation, removed redundant fields for TR

Signed-off-by: pujavs <pujas.works@gmail.com>

---------

Signed-off-by: pujavs <pujas.works@gmail.com>
Former-commit-id: d36fc80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: add validation for asset mgt module
4 participants