Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testcontainers-java pervert running the test suite with scylladb/scylla docker image #2351

Closed
fruch opened this issue Jan 11, 2021 · 1 comment · Fixed by #2352
Closed

testcontainers-java pervert running the test suite with scylladb/scylla docker image #2351

fruch opened this issue Jan 11, 2021 · 1 comment · Fixed by #2352
Labels
kind/bug/confirmed storage/scylladb

Comments

@fruch
Copy link
Contributor

fruch commented Jan 11, 2021 •
edited
Loading

Recently the docker base tests for scylladb stopped working
the last confirmed one that was working (in our CI) was c97e84e

$ java -version
java version "1.8.0_201"
Java(TM) SE Runtime Environment (build 1.8.0_201-b09)
Java HotSpot(TM) 64-Bit Server VM (build 25.201-b09, mixed mode)

$ mvn clean install -pl janusgraph-cql -Pscylladb
...
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.085 s <<< FAILURE! - in org.janusgraph.diskstorage.cql.CQLDistributedStoreManagerTest                                              
[ERROR] org.janusgraph.diskstorage.cql.CQLDistributedStoreManagerTest  Time elapsed: 0.085 s  <<< ERROR!                                                                                                     
java.lang.ExceptionInInitializerError                                                                                                                                                                        
        at org.janusgraph.diskstorage.cql.CQLDistributedStoreManagerTest.<clinit>(CQLDistributedStoreManagerTest.java:37)

closer look seem to there a new PR
testcontainers/testcontainers-java#3021

that breaks taking scylla docker as a drop in replacement in the tests...
since the docker image name doesn't start with "cassandra"...

running the test suite with the cassandra docker image does work...

Any ideas on how it can be solved ?
@farodin91
Copy link
Contributor

You should be able to open a pull request for testcontainers to allow Scylla as a valid container.

fruch added a commit to fruch/janusgraph that referenced this issue Jan 11, 2021
@fruch
Make any passed cassandra image consider as comptiable
69bfb94 
since `scylladb/scylla` were comptible out of the box for
testcontinars, we now enable any docker image to be cosider as
cassandra comptible

Fixes: JanusGraph#2351
@fruch fruch mentioned this issue Jan 11, 2021
Merged
9 tasks
fruch added a commit to fruch/janusgraph that referenced this issue Jan 11, 2021
@fruch
Make any passed cassandra image consider as comptiable
d52ddab 
since `scylladb/scylla` were comptible out of the box for
testcontinars, we now enable any docker image to be cosider as
cassandra comptible

Fixes: JanusGraph#2351
Signed-off-by: Israel Fruchter <fruch@scylladb.com>
fruch added a commit to fruch/janusgraph that referenced this issue Feb 15, 2021
@fruch
Make any passed cassandra image consider as comptiable
92fbee5 
since `scylladb/scylla` were comptible out of the box for
testcontinars, we now enable any docker image to be cosider as
cassandra comptible

Fixes: JanusGraph#2351
Signed-off-by: Israel Fruchter <fruch@scylladb.com>
fruch added a commit to fruch/janusgraph that referenced this issue Feb 21, 2021
@fruch
Make any passed cassandra image consider as comptiable
9ca4a5e 
since `scylladb/scylla` were comptible out of the box for
testcontinars, we now enable any docker image to be cosider as
cassandra comptible

Fixes: JanusGraph#2351
Signed-off-by: Israel Fruchter <fruch@scylladb.com>
fruch added a commit to fruch/janusgraph that referenced this issue Mar 3, 2021
@fruch
Make any passed cassandra image consider as comptiable
66e2840 
* since `scylladb/scylla` were comptible out of the box for
  testcontinars, we now enable any docker image to be cosider as
  cassandra comptible

* Github actions: add tests based on scylladb

Fixes: JanusGraph#2351
Signed-off-by: Israel Fruchter <fruch@scylladb.com>
li-boxuan pushed a commit that referenced this issue Mar 7, 2021
@fruch @li-boxuan
Make any passed cassandra image consider as comptiable
997902d 
* since `scylladb/scylla` were comptible out of the box for
  testcontinars, we now enable any docker image to be cosider as
  cassandra comptible

* Github actions: add tests based on scylladb

Fixes: #2351
Signed-off-by: Israel Fruchter <fruch@scylladb.com>
@FlorianHockmann FlorianHockmann mentioned this issue May 28, 2021
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug/confirmed storage/scylladb
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make any passed cassandra image consider as compatible fruch/janusgraph
3 participants
@fruch @farodin91 @li-boxuan