Bump actions/upload-artifact from 3 to 4

[dependabot]

Bumps actions/upload-artifact from 3 to 4.

Release notes

Sourced from actions/upload-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

For more information, see the @​actions/artifact documentation.

New Contributors

• @​vmjoseph made their first contribution in actions/upload-artifact#464

Full Changelog: actions/upload-artifact@v3...v4.0.0

v3.1.3

What's Changed

• chore(github): remove trailing whitespaces by @​ljmf00 in actions/upload-artifact#313
• Bump @​actions/artifact version to v1.1.2 by @​bethanyj28 in actions/upload-artifact#436

Full Changelog: actions/upload-artifact@v3...v3.1.3

v3.1.2

• Update all @actions/* NPM packages to their latest versions- #374
• Update all dev dependencies to their most recent versions - #375

v3.1.1

• Update actions/core package to latest version to remove set-output deprecation warning #351

v3.1.0

What's Changed

• Bump @​actions/artifact to v1.1.0 (actions/upload-artifact#327)
  • Adds checksum headers on artifact upload (actions/toolkit#1095) (actions/toolkit#1063)

Commits

• c7d193f Merge pull request #466 from actions/v4-beta
• 13131bb licensed cache
• 4a6c273 Merge branch 'main' into v4-beta
• f391bb9 Merge pull request #465 from actions/robherley/v4-documentation
• 9653d03 Apply suggestions from code review
• 875b630 add limitations section
• ecb2146 add compression example
• 5e7604f trim some repeated info
• d6437d0 naming
• 1b56155 s/v4-beta/v4/g
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[FlorianHockmann]

Looks like there was a breaking change which now breaks our builds. Seems like we're creating multiple times an artifact with the same name which isn't allowed any more in v4: actions/upload-artifact#471.
This seems to be caused by jacoco as we have multiple times the same config to upload reports like this:

      - uses: actions/upload-artifact@v3
        with:
          name: jacoco-reports
          path: target/jacoco-combined.exec

I haven't looked further into this and I also don't know how jacoco works so I can't say whether we can simply change the name here or how else we can deal with this. (Just wanted to write my findings down so far in case any one else also wants to look into it.)

[li-boxuan]

I am not sure if this is the right approach, but probably something like this might work:

- uses: actions/upload-artifact@v4
  with:
    name: jacoco-reports-${{ matrix.module }}-java-${{ matrix.java }}
    path: target/jacoco-combined.exec

[FlorianHockmann]

I am not sure if this is the right approach, but probably something like this might work:

I updated the commit to try out your suggestion. Let's see whether this fixes the failing builds.

[FlorianHockmann]

OK, this took me several attempts to fix it for all cases, but now all builds are green and this is therefore ready for review again. I had to rename some elements of a matrix to get unique names as they could only be identified by their args, but the args also contain invalid characters if we wanted to use them as an artifact name.
I'll merge this after 7 days if nobody reviews it until then.

[li-boxuan]

Thank you for taking care of this. Just two minor nits:

[janusgraph-automations]

💚 All backports created successfully

Status	Branch	Result
✅	v1.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details