Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to elevate or disable rate limits for keys #54

Closed
themightychris opened this issue Aug 28, 2018 · 3 comments
Closed

Ability to elevate or disable rate limits for keys #54

themightychris opened this issue Aug 28, 2018 · 3 comments
Assignees
Milestone

Comments

@themightychris
Copy link
Member

Each key should be able to be granted partial or full immunity from rate limits

@themightychris themightychris added this to the v3.0 milestone Aug 28, 2018
@themightychris themightychris self-assigned this Aug 28, 2018
@themightychris
Copy link
Member Author

Given that rate limits are defined per-endpoint, being able to elevate rather than fully remove late limits could complicate endpoint configuration greatly. It is also complicated to consider how an API user with merely elevated rate limits would impact others users of the same endpoint (i.e. do the hits of an elevated user reduce the number of hits available to normal users? if so, are they fractional?)

To start, let's only implement the ability to exempt certain keys from rate limits entirely, so they will neither ever be denied or consume the public hit bucket.

@nbey nbey self-assigned this May 24, 2020
@themightychris themightychris modified the milestones: v3.0, v3.1 Jun 11, 2020
@nbey
Copy link
Contributor

nbey commented Jun 25, 2020

@themightychris RE: Global Rate Limit Exempt IP patterns editable via CMS

Currently, the Globally Exempt requests are set per key.

Should we create a new ActiveRecord, and if so do you have any model name suggestions?

@themightychris
Copy link
Member Author

closed by #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants