Feat: Rate limit exempt keys #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themightychris
requested changes
Jun 7, 2020
There was a problem hiding this comment.
Looks great overall, take a pass through though and try to minimize any extra diff content, there are a few more beyond the ones I noted.
Also in the cases where one if block got wrapped in a second, let's combine those and break the conditions out to multiple lines rather than nest everything an extra level deep and touch every line with an indent shift
event-handlers/Gatekeeper/ApiRequestHandler/afterApiRequest/10_register-response.php
Outdated
Show resolved
Hide resolved
event-handlers/Gatekeeper/ApiRequestHandler/afterApiRequest/10_register-response.php
Outdated
Show resolved
Hide resolved
event-handlers/Gatekeeper/ApiRequestHandler/afterApiRequest/10_register-response.php
Outdated
Show resolved
Hide resolved
|
Ok after a few commits worth of chores, I believe the changes have been minimized to what's needed. The commit history is sorta bloated now, lmk if you want me to create a new branch or clean up the clean ups 😄 |
nbey
force-pushed
the
feat/rate-limit-exempt-keys
branch
from
dee4790 to
a5fb25b
Compare
This was referenced Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves Issue #54