Don't resolve collections for not registered types when IServiceProviderIsService is used - GH-391 #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rizi
force-pushed
the
Fix-GH-391-Dont-Resolve-Collections-For-Not-Registered-Type
branch
from
0e52b99
to
35dccbb
Compare
…derIsService is used, in this case the model binder of aps.net core should create the object. Closes JasperFxGH-391
rizi
force-pushed
the
Fix-GH-391-Dont-Resolve-Collections-For-Not-Registered-Type
branch
from
35dccbb
to
4c11f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment Lamar is used to resolve collection types in methods of web api controllers, therefore the collections are always empty (no matter which values are available in the body of the request).
With this change Lamar will not be used to resolve collection types when the type (e.g IReadOnlyCollection --> UpdateCommand) is not explicitly registered, therefore the asp.net core model builder kicks in and the creates the collection (as expected).
This PR closes #391.