ProjectView / DeleteEvent not run when rebuilding projections

[sturatcliffe]

When using ProjectView to configure a DeleteEvent as documented here:

http://jasperfx.github.io/marten/documentation/events/projections/custom/

My projected document is deleted as expected. However, when rebuilding projections as documented here:

http://jasperfx.github.io/marten/documentation/events/projections/#sec3

My projected document appears again. It seems that ProjectView is not run when rebuilding projections. A sample console app to show this can be found here:

https://github.com/sturatcliffe/MartenProjectViewIssue

[oskardudycz]

@sturatcliffe just giving you heads up - I'm working on it, I hope that I'll come up with something this weak.

[ericgreenmix]

@oskardudycz Any update on your work on this? I hit this issue today.

[oskardudycz]

@ericgreenmix I was working on that, but it ended up with the refactoring. It's visible on draft PR #1322. Although after discussion with @jeremydmiller we will probably go deeper with refactoring. See more here: #1307 (you can put there also your comments about your thoughts/ideas).

If this is blocking you I can try to come up with some hotfix.

[ericgreenmix]

Cool. We are not majorly impacted by this at-the-moment. We only have one projection has the

opt.Events.InlineProjections.AggregateStreamsWith<Project>();
opt.Events.ProjectView<Project, Guid>().DeleteEvent<ProjectDeleted>();

format. I think we can actually convert it to a ViewProjection, not using AggregateStreamsWith and get around this issue.

I have been reading through #1307 and will post some thoughts when I get time tomorrow.

[oskardudycz]

@sturatcliffe @ericgreenmix please have a look on #1483

It seems that the issue was fixed in one of the previous releases. I copied the repro from the linked project https://github.com/sturatcliffe/MartenProjectViewIssue.

Could you confirm that it works fine now?

[oskardudycz]

@sturatcliffe @ericgreenmix I managed to reproduce that. Fix will be available in 3.12.0

[oskardudycz]

@ericgreenmix @sturatcliffe, unfortunately, I needed to step back from the change, as it brought the regression. Fixing that would require either ugly hacks or rewrite the current solution. However that will happen in v4, so I'm reopening that and marking with v4 milestone.

[jeremydmiller]

Everybody, the mechanics are so different in V4 that I don't believe this issue matters. There is no ProjectView() in V4, and the delete events are working with the new AggregateProjection