Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Foundation onboarding #1436

Merged
merged 10 commits into from
Mar 16, 2020
Merged

.Net Foundation onboarding #1436

merged 10 commits into from
Mar 16, 2020

Conversation

oskardudycz
Copy link
Collaborator

@oskardudycz oskardudycz commented Mar 10, 2020

  1. Updated Licence to include required "Copyright (c) .NET Foundation and Contributors"
  2. Updated README to contain:
  • License information,
  • Code of Conduct link,
  • .NET Foundation information,
  • Twitter Badge
  1. Updated project documentation with information about .NET Foundation support.
  2. Added Contribution guidelines document.

@oskardudycz oskardudycz added this to the 3.11.0 milestone Mar 10, 2020
This was referenced Mar 10, 2020
Copy link
Member

@mysticmind mysticmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment, everything else looks fine.

LICENSE Outdated
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2015 JasperFx
Copyright (c) .NET Foundation and Contributors
Copy link
Member

@mysticmind mysticmind Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to the following so that it is inline with the readme content?

Copyright © .NET Foundation, Jeremy D. Miller, Babu Annamalai, Oskar Dudycz, Joona-Pekka Kokko and contributors.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid point. Updated 👍

@mysticmind
Copy link
Member

We will need to update our docs site as well.

@oskardudycz
Copy link
Collaborator Author

@mysticmind yes, that's correct. I have plan to provide the changes later on today.

@mysticmind
Copy link
Member

Marten is listing in .NET Foundation site now - https://dotnetfoundation.org/projects?searchquery=marten&type=project

Copy link
Collaborator

@jokokko jokokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated
@@ -38,10 +39,12 @@ _Help with PSQL/PLV8_
- On Windows, see [this link](http://www.postgresonline.com/journal/archives/360-PLV8-binaries-for-PostgreSQL-9.5-windows-both-32-bit-and-64-bit.html) for pre-built binaries of PLV8
- On *nix, check [marten-local-db](https://github.com/eouw0o83hf/marten-local-db) for a Docker based PostgreSQL instance including PLV8.

Once you have the codebase and the connection string file, run the rake script or use the dotnet CLI to restore and build the solution.
Once you have the codebase and the connection string file, run the rake build or use the dotnet CLI to restore and build the solution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to refer to the Bullseye build. We've got build.cmd shortcuts now too, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wanted to replace rake with build, but I accidentaly replaced wrong word 😉 Updated 👍

@jeremydmiller
Copy link
Member

I've just got the one comment about rake

@oskardudycz oskardudycz merged commit 12842f5 into master Mar 16, 2020
@oskardudycz oskardudycz deleted the netfoundation branch March 16, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants