-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Foundation onboarding #1436
Conversation
oskardudycz
commented
Mar 10, 2020
•
edited
Loading
edited
- Updated Licence to include required "Copyright (c) .NET Foundation and Contributors"
- Updated README to contain:
- License information,
- Code of Conduct link,
- .NET Foundation information,
- Twitter Badge
- Updated project documentation with information about .NET Foundation support.
- Added Contribution guidelines document.
Added also Twitter badge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment, everything else looks fine.
LICENSE
Outdated
@@ -1,6 +1,6 @@ | |||
The MIT License (MIT) | |||
|
|||
Copyright (c) 2015 JasperFx | |||
Copyright (c) .NET Foundation and Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be updated to the following so that it is inline with the readme content?
Copyright © .NET Foundation, Jeremy D. Miller, Babu Annamalai, Oskar Dudycz, Joona-Pekka Kokko and contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid point. Updated 👍
We will need to update our docs site as well. |
@mysticmind yes, that's correct. I have plan to provide the changes later on today. |
Marten is listing in .NET Foundation site now - https://dotnetfoundation.org/projects?searchquery=marten&type=project |
Formatted build commands table.
8d16c5c
to
35505a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
README.md
Outdated
@@ -38,10 +39,12 @@ _Help with PSQL/PLV8_ | |||
- On Windows, see [this link](http://www.postgresonline.com/journal/archives/360-PLV8-binaries-for-PostgreSQL-9.5-windows-both-32-bit-and-64-bit.html) for pre-built binaries of PLV8 | |||
- On *nix, check [marten-local-db](https://github.com/eouw0o83hf/marten-local-db) for a Docker based PostgreSQL instance including PLV8. | |||
|
|||
Once you have the codebase and the connection string file, run the rake script or use the dotnet CLI to restore and build the solution. | |||
Once you have the codebase and the connection string file, run the rake build or use the dotnet CLI to restore and build the solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to refer to the Bullseye build. We've got build.cmd shortcuts now too, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wanted to replace rake
with build
, but I accidentaly replaced wrong word 😉 Updated 👍
I've just got the one comment about rake |