Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2945): AsyncDaemonHealthCheck - add maxSameLagTime option #2950

Conversation

MateuszNaKodach
Copy link
Contributor

@MateuszNaKodach MateuszNaKodach commented Feb 7, 2024

First implementation version to discuss for:
#2945

This PR also fixes bug in the previous implementation: Unhelathy state when no events stored and HighWaterMark not present.

disclaimer:
I may use FakeTimeProvider from Microsoft.Extensions.TimeProvider.Testing for tests, but:

Install failed (project: Marten.AsyncDaemon.Testing, package: Microsoft.Extensions.TimeProvider.Testing v8.1.0) Package restore failed. Rolling back package changes for 'Marten.AsyncDaemon.Testing'. Detected package version outside of dependency constraint: Lamar 12.1.0 requires Microsoft.Extensions.DependencyInjection.Abstractions (>= 6.0.0 && 8.0.0) but version Microsoft.Extensions.DependencyInjection. ... e this issue. Marten.AsyncDaemon.Testing -> Microsoft.Extensions.TimeProvider.Testing 8.1.0 -> Microsoft.Bcl.TimeProvider 8.0.1 -> Microsoft.Bcl.AsyncInterfaces (>= 8.0.0) Marten.AsyncDaemon.Testing -> EventSourcingTests -> Lamar 12.1.0 -> Microsoft.Bcl.AsyncInterfaces (>= 6.0.0 && 8.0.0).

@MateuszNaKodach MateuszNaKodach changed the title feat(#2945): AsyncDaemonHealthCheck - add maxSameLagTime option feat(#2945): AsyncDaemonHealthCheck - add maxSameLagTime option Feb 7, 2024
@jeremydmiller
Copy link
Member

@MateuszNaKodach I'd like to just take this in for now, but consider any further concerns as part of the grander "how do we manage projections in production" story here: #2968

@jeremydmiller
Copy link
Member

And I'll deal w/ the fussy markdown lint stuff, no worries on that account.

@jeremydmiller jeremydmiller merged commit 31da385 into JasperFx:master Feb 21, 2024
9 of 11 checks passed
@jeremydmiller
Copy link
Member

Got it from the CLI. @MateuszNaKodach Big thanks for this one!

@MateuszNaKodach
Copy link
Contributor Author

@jeremydmiller Thanks a lot :) It was a pleasure to add this nano portion of code to such a great project as Marten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants