F# discriminated union support for strongly-typed identifiers #3279
Conversation
…eat F# discriminated unions (DUs) as candidates - Modified the RegistereValueTypes method in StoreOptions.MemberFactory.cs to support registering types representing single case F# discriminated unions matching naming policy - Removing the struct constraint to the TOuter generic parameter on the class StrongTypedIdSelectClause to support reference types (since F# DUs are represents by abstract classes) caused an obscure runtime cast issue in the BuildHandler<TResult> method when value types are used. The cast error was related to the fact that value type is wrapped into a nullable when the struct constraint is removed.I therefore introduced the intermediary types INullableQueryHandler<T> where T : struct and NullableListQueryHandler<T> and implementing it to facilitate this cast for value types. To bypass compiler limitations to the inferred type of TResult in BuildHandler<TResult>, NullableListQueryHandler<TResult> lists (only used for value types) are instanciated dynamically. - Added test cases to existing tests in applicability_of_identity_types.cs to verify that classes representing F# DUs are correctly registered and detected as candidates - Added a test class for F# DUs but for example the tests are just a copy-and-paste of other test cases Status: awaiting implementation of all tests in F#
…identifiers - Added a couple of utility methods Used a wrong reference for the class representing F# single-case DUs (there is no nested class in this case). Awaiting changes in an upcoming commit
…e f# compiler does not generate nested classes for single case discriminated), the implementation has been adjusted (and simplified) accordingly
… made the necessary adjustments - Added missing test cases - Added F# project to test against actual F# types - All tests are (finally) passing!!!
nkosi23
changed the title
|
Edit: okay, was tired and read too fast the code about Comb Guids. just figured comb guids can be generated externally from my code as they actually only depend on a timestamp. I guess I'll just create and inject a Guid generation service in my project that will use Marten's |
…e F# SystemTextJson serializer
… was actually testing)
…Generation strategy
|
@nkosi23 Can you reverse the rename of |
|
@jeremydmiller Thanks for the feedback, I've just reverted it |
Implements #3280