Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardening the Kafka JSON only publishing for messages pulled from the… #1120

Merged
merged 1 commit into from
Nov 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Transports/Kafka/Wolverine.Kafka/IKafkaEnvelopeMapper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,20 @@ public JsonOnlyMapper(KafkaTopic topic, JsonSerializerOptions options)
public void MapEnvelopeToOutgoing(Envelope envelope, Message<string, string> outgoing)
{
outgoing.Key = envelope.GroupId;
outgoing.Value = JsonSerializer.Serialize(envelope.Message, _options);

if (envelope.Data != null && envelope.Data.Any())
{
outgoing.Value = Encoding.Default.GetString(envelope.Data);
}
else if (envelope.Message != null)
{
outgoing.Value = JsonSerializer.Serialize(envelope.Message, _options);
}
else
{
throw new InvalidOperationException(
$"Envelope {envelope.Id} has neither {nameof(envelope.Data)} nor {nameof(Envelope.Message)}");
}
}

public void MapIncomingToEnvelope(Envelope envelope, Message<string, string> incoming)
Expand Down
Loading