Tolerate trailing semicolon in RabbitMQ connection string

[igor-toporet]

Usually, database connection strings contain a trailing semicolon after the last "key=value;" pair.

I'm proposing this change to respect the principle of least astonishment and keep RabbitMQ connection strings consistent with other connection strings in the application configuration. I spent some time today figuring out what's wrong; I hope it'll save other people's time in the future, too.

---

An alternative fix would be to change JasperFx.CoreStringExtensions.ToDelimitedArray to use StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries as it doesn't seem that any usage in JasperFx repositories is interested in empty entries after splitting a delimited string. (See https://github.com/search?q=org%3AJasperFx+ToDelimitedArray&type=code)

Trimming entries won't be needed, too, on the line 244

array[i] = array[i].Trim();

---

UPDATE: JasperFx/JasperFx.Core#10

[igor-toporet]

I'm not sure the build failure is related to my changes.

[igor-toporet]

The test failure does not reproduce locally. It could be a flaky test (suite).

[jeremydmiller]

@igor-toporet You could have just done a TrimEnd(';') first

[igor-toporet]

@igor-toporet You could have just done a TrimEnd(';') first

🤦 indeed 😄 sometimes obvious solution doesn't come to mind.

Should I close the PR?